feat(proxy-wasm): Add new request property request.is_subrequest
#663
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
====================================================
- Coverage 90.82650% 64.00078% -26.82572%
====================================================
Files 53 52 -1
Lines 11337 10253 -1084
Branches 1692 0 -1692
====================================================
- Hits 10297 6562 -3735
- Misses 1034 3691 +2657
+ Partials 6 0 -6
... and 50 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Introduce a new request property `request.is_subrequest` to indicate whether the current request is a subrequest of an existing request (e.g., in slicing scenarios). Note: Although the property uses the `request.*` prefix, this is not an Envoy attribute.
dev-null-undefined
force-pushed
the
feat/request.is_subrequest
branch
from
99bfad0 to
ba0d121
Compare
|
Thank you. It looks like another test in the same suite is missing the new property and causing all these CI failures. |
|
|
||
| if (r == r->main) { | ||
| ngx_str_set(value, "false"); | ||
| } else { |
There was a problem hiding this comment.
The linter will also complain about this else which is missing the blank line above. We should actually do this logic like connection.mtls, and move the static true/false strings outside of the mtls getter so that we can have the same value = r == r->main ? true : false logic (see connection.mtls getter).
|
A rebase on main will also be necessary as it will fix the other CI issues. |
|
Merged with edits in #666. Thank you! |
Introduce a new request property
request.is_subrequestto indicate whether the current request is a subrequest of an existing request (e.g., in slicing scenarios).Note: Although the property uses the
request.*prefix, this is not an Envoy attribute.Fixes #658