Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): update comment #77

Merged
merged 2 commits into from
May 28, 2024
Merged

feat(markdown): update comment #77

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c30595d
feat(markdown): update comment
aanchalm01 May 21, 2024
f287918
feat(markdown): update comment
aanchalm01 May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/MarkdownUi.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ onUnmounted(() => {
destroySyncScroll()
})

// Exposing for Integrated Markdown Editor - Milestone 2 (Creating a New Document) work. The download and edit will be managed by the host app.
// The download and edit will be managed by the host app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The download and edit will be managed by the host app.
// The download and edit can be managed by the host app.

defineExpose({ download, edit })

// Calculate the max height of the `.markdown-panes` when fullscreen is true. 100vh, minus the toolbar height, minus 10px padding.
Expand Down