Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): update comment #77

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

aanchalm01
Copy link
Contributor

Summary

@aanchalm01 aanchalm01 requested review from adamdehaven, jillztom and a team as code owners May 21, 2024 18:25
@aanchalm01
Copy link
Contributor Author

@adamdehaven: updated the comment

@aanchalm01 aanchalm01 enabled auto-merge (squash) May 21, 2024 18:25
@@ -553,7 +553,7 @@ onUnmounted(() => {
destroySyncScroll()
})

// Exposing for Integrated Markdown Editor - Milestone 2 (Creating a New Document) work. The download and edit will be managed by the host app.
// The download and edit will be managed by the host app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The download and edit will be managed by the host app.
// The download and edit can be managed by the host app.

@aanchalm01 aanchalm01 self-assigned this May 28, 2024
@aanchalm01 aanchalm01 requested a review from adamdehaven May 28, 2024 15:40
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aanchalm01 aanchalm01 merged commit 1df2b64 into main May 28, 2024
4 checks passed
@aanchalm01 aanchalm01 deleted the chore/update-comment-definexpose branch May 28, 2024 16:00
kongponents-bot pushed a commit that referenced this pull request May 28, 2024
# [1.5.0](v1.4.1...v1.5.0) (2024-05-28)

### Features

* **markdown:** update comment ([#77](#77)) ([1df2b64](1df2b64))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Install the preview package from this PR

@kong/markdown@pr-77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants