Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fail integration-tests-passed when tests don't pass #869

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

programmer04
Copy link
Member

PR #867 bumped image from 3.3.-alpine to 3.4-alpine despite failures in tests (this and that) it was successfully merged.

This PR fixes it, it should not allow merge when any test fails, a fix for a bump of the image is in

@programmer04
Copy link
Member Author

Failed as expected see - rebasing on main that includes #868 to pass all tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34c766a) 60.08% compared to head (a71f9cd) 52.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   60.08%   52.08%   -8.01%     
==========================================
  Files          49       49              
  Lines        4024     4024              
==========================================
- Hits         2418     2096     -322     
- Misses       1301     1663     +362     
+ Partials      305      265      -40     
Flag Coverage Δ
integration-test 52.08% <ø> (-8.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 merged commit 49919da into main Nov 7, 2023
40 checks passed
@programmer04 programmer04 deleted the fix-ci branch November 7, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants