Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Kong Gateway Enterprise default image to Ubuntu #868

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Nov 7, 2023

PR #867 bumped image from 3.3.-alpine to 3.4-alpine despite failures in tests (this and that) it was successfully merged. A fix for this to not allow merging is presented in

Since 3.4 the Alpine image is no longer built, the recommended one is Ubuntu so this PR is setting it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5395af) 56.85% compared to head (46b0be9) 60.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   56.85%   60.31%   +3.45%     
==========================================
  Files          49       49              
  Lines        4024     4024              
==========================================
+ Hits         2288     2427     +139     
+ Misses       1452     1293     -159     
- Partials      284      304      +20     
Flag Coverage Δ
integration-test 60.31% <ø> (+3.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/clusters/addons/kong/addon.go 63.81% <ø> (+15.57%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek
Copy link
Member

pmalek commented Nov 7, 2023

Given that integration-tests-passed check if required how did we end up merging #867 🤔 ? Wasn't that the case at the time it was merged? Did the required checks changed since then?

@pmalek
Copy link
Member

pmalek commented Nov 7, 2023

Given that integration-tests-passed check if required how did we end up merging #867 🤔 ? Wasn't that the case at the time it was merged? Did the required checks changed since then?

I see https://github.com/Kong/kubernetes-testing-framework/pull/869/files

@programmer04 programmer04 merged commit 34c766a into main Nov 7, 2023
40 checks passed
@programmer04 programmer04 deleted the fix-bump branch November 7, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants