Add counter for admissions

[dweber019]

What this PR does / why we need it:

Adding a counter to observe admissions.
Additionally, I moved the creation of the metrics store to share the instance.

Which issue this PR fixes:

Fixes #6084

Special notes for your reviewer:

Pretty new to golang and this project, feedback welcome 😉

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

• the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

[pmalek]

This looks solid 👍

1 thing that this is missing is adding this metric in the list of expected metrics in

kubernetes-ingress-controller/test/envtest/metrics_envtest_test.go

Lines 38 to 45 in 447b3ae

	wantMetrics := []string{
	metrics.MetricNameConfigPushCount,
	metrics.MetricNameConfigPushBrokenResources,
	metrics.MetricNameTranslationCount,
	metrics.MetricNameTranslationBrokenResources,
	metrics.MetricNameConfigPushDuration,
	metrics.MetricNameConfigPushSuccessTime,
	}

Additionally: would you also be interested in contributing this new metric description to docs https://docs.konghq.com/kubernetes-ingress-controller/latest/production/observability/prometheus/ ? The source is located at: https://github.com/Kong/docs.konghq.com/blob/e3f336ea4f63c6808d9ab40ed7f522ef47ff27fc/app/_src/kubernetes-ingress-controller/production/observability/prometheus.md

[dweber019]

Thx, having a look this evening.

[dweber019]

Added changes and PR for documentation is open at Kong/docs.konghq.com#7429

[pmalek]

@dweber019 FYI: our CI configuration currently doesn't allow contributions from forks (ref: #3745). When that's resolved we'll be able to merge this PR.

[dweber019]

So should I create a feature branch directly on this repo?

[pmalek]

branch

You won't be able to unless you're a contributor/org member with write access. Sorry for any inconvenience caused.

[dweber019]

OK so I understand that I wait for #3745. Hope get's resolved soon 😉

[pmalek]

OK so I understand that I wait for #3745. Hope get's resolved soon 😉

@dweber019 With #3745 merged now, you can try rebasing on main.