-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add INFO log for admissions which aren't allowed #6086
Conversation
452af5e
to
e3bf5a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, other than that 👍
Signed-off-by: David Weber <[email protected]>
e3bf5a4
to
7893b49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@lahabana please sign CLA and we're good to go |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6086 +/- ##
=====================================
Coverage 74.1% 74.2%
=====================================
Files 202 202
Lines 20492 20539 +47
=====================================
+ Hits 15198 15244 +46
- Misses 4274 4287 +13
+ Partials 1020 1008 -12 ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it:
It will add a INFO log message when an admission isn't allowed. This helps debugging and monitoring.
Which issue this PR fixes:
Fixes #6084
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR