Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip enterprise tests when image is enterprise but TEST_KONG_ENTERPRISE not enabled #5165

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Nov 15, 2023

What this PR does / why we need it:

Skip the test cases requiring enterprise features when TEST_KONG_ENTERPRISE is not set to true. This prevents the enterprise test cases to run if enterprise version of Kong image used, but TEST_KONG_ENTERPRISE is not set thus fails on the tests, because license is not initialized in such case.

Which issue this PR fixes:

fixes #5045
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR CHANGELOG not required

@randmonkey randmonkey requested a review from a team as a code owner November 15, 2023 10:18
@randmonkey randmonkey marked this pull request as draft November 15, 2023 10:18
@team-k8s-bot
Copy link
Collaborator

Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975436 with the following parameters:

{
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
}

@team-k8s-bot
Copy link
Collaborator

Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975838 with the following parameters:

{
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
}

@team-k8s-bot
Copy link
Collaborator

Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975485 with the following parameters:

{
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
}

@team-k8s-bot
Copy link
Collaborator

Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975638 with the following parameters:

{
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
}

@team-k8s-bot
Copy link
Collaborator

Kong Gateway validation tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6876100637 with the following parameters:

{
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
}

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21a05ab) 77.8% compared to head (df77f78) 78.0%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5165     +/-   ##
=======================================
+ Coverage   77.8%   78.0%   +0.1%     
=======================================
  Files        168     168             
  Lines      18896   18896             
=======================================
+ Hits       14712   14744     +32     
+ Misses      3354    3329     -25     
+ Partials     830     823      -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@team-k8s-bot
Copy link
Collaborator

Kong Gateway validation tests PASSED ✅ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6876100637 with the following parameters:

{
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
}

@randmonkey randmonkey reopened this Nov 15, 2023
@randmonkey randmonkey marked this pull request as ready for review November 15, 2023 15:30
@randmonkey randmonkey added this to the Fixit 2023 milestone Nov 15, 2023
@randmonkey randmonkey enabled auto-merge (squash) November 16, 2023 09:30
@randmonkey randmonkey merged commit bab7280 into main Nov 16, 2023
226 of 258 checks passed
@randmonkey randmonkey deleted the test/skip_tests_requiring_enterprise branch November 16, 2023 11:26
randmonkey added a commit that referenced this pull request Nov 21, 2023
randmonkey added a commit that referenced this pull request Nov 21, 2023
* add kong-effective-version input in validate kong image tests (#5074)

* skip enterprise tests when image is enterprise but TEST_KONG_ENTERPRISE not enabled (#5165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix validating Kong image tests
3 participants