-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip enterprise tests when image is enterprise but TEST_KONG_ENTERPRISE not enabled #5165
Conversation
Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975436 with the following parameters: {
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
} |
Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975838 with the following parameters: {
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
} |
Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975485 with the following parameters: {
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
} |
Kong Gateway validation tests FAILED ❌ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6875975638 with the following parameters: {
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
} |
Kong Gateway validation tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6876100637 with the following parameters: {
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
} |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5165 +/- ##
=======================================
+ Coverage 77.8% 78.0% +0.1%
=======================================
Files 168 168
Lines 18896 18896
=======================================
+ Hits 14712 14744 +32
+ Misses 3354 3329 -25
+ Partials 830 823 -7 ☔ View full report in Codecov by Sentry. |
Kong Gateway validation tests PASSED ✅ at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6876100637 with the following parameters: {
"e2e-controller-image-repo": "kong/kubernetes-ingress-controller",
"e2e-controller-image-tag": "latest",
"issue-number": "5165",
"kong-effective-version": "3.5.0",
"kong-image-repo": "kong/kong-gateway",
"kong-image-tag": "3.5.0.0"
} |
What this PR does / why we need it:
Skip the test cases requiring enterprise features when
TEST_KONG_ENTERPRISE
is not set totrue
. This prevents the enterprise test cases to run if enterprise version of Kong image used, butTEST_KONG_ENTERPRISE
is not set thus fails on the tests, because license is not initialized in such case.Which issue this PR fixes:
fixes #5045
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:- [x] theCHANGELOG not requiredCHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR