Skip to content

Commit

Permalink
skip enterprise tests when image is enterprise but TEST_KONG_ENTERPRI…
Browse files Browse the repository at this point in the history 
…SE not enabled (#5165)
  • Loading branch information
@randmonkey
randmonkey committed Nov 21, 2023
1 parent ed5484d commit a1a04ea
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test/integration/version_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

"github.com/kong/kubernetes-ingress-controller/v2/test/consts"
"github.com/kong/kubernetes-ingress-controller/v2/test/internal/helpers"
"github.com/kong/kubernetes-ingress-controller/v2/test/internal/testenv"
)

func RunWhenKongVersion(t *testing.T, vRangeStr string, msg ...any) {
Expand Down Expand Up @@ -52,6 +53,10 @@ func RunWhenKongDBMode(t *testing.T, dbmode string, msg ...any) {
func RunWhenKongEnterprise(t *testing.T) {
t.Helper()

if !testenv.KongEnterpriseEnabled() {
t.Skipf("skipping because Kong enterprise is not enabled")
}

version := eventuallyGetKongVersion(t, proxyAdminURL)

if !version.IsKongGatewayEnterprise() {
Expand Down

4 comments on commit a1a04ea

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: a1a04ea Previous: af02760 Ratio
BenchmarkDeckgenGenerateSHA - ns/op 76894 ns/op 29880 ns/op 2.57
BenchmarkDefaultContentToDBLessConfigConverter_Convert - ns/op 136.7 ns/op 71.88 ns/op 1.90

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Kong/k8s-maintainers

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: a1a04ea Previous: af02760 Ratio
BenchmarkDeckgenGenerateSHA - ns/op 75159 ns/op 29880 ns/op 2.52
BenchmarkDefaultContentToDBLessConfigConverter_Convert - ns/op 131.2 ns/op 71.88 ns/op 1.83

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Kong/k8s-maintainers

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: a1a04ea Previous: af02760 Ratio
BenchmarkDeckgenGenerateSHA - ns/op 75790 ns/op 29880 ns/op 2.54

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Kong/k8s-maintainers

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: a1a04ea Previous: af02760 Ratio
BenchmarkDeckgenGenerateSHA - ns/op 72622 ns/op 29880 ns/op 2.43
BenchmarkDefaultContentToDBLessConfigConverter_Convert - ns/op 126.8 ns/op 71.88 ns/op 1.76

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Kong/k8s-maintainers

Please sign in to comment.