Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kalert): slotted links default styling [KHCP-14152] #2528

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(kalert): slotted links default styling [KHCP-14152] #2528

merged 1 commit into from
Nov 26, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Nov 26, 2024

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-14152

Add default styling for slotted links in KAlert

Screenshot 2024-11-26 at 3 49 05 PM

@portikM portikM self-assigned this Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 6e1688a
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6746348340196200080908c1
😎 Deploy Preview https://deploy-preview-2528--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM enabled auto-merge (squash) November 26, 2024 20:50
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 6e1688a
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67463482f9622c0008eb6911
😎 Deploy Preview https://deploy-preview-2528--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adamdehaven
adamdehaven approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM merged commit 631a287 into main Nov 26, 2024
11 checks passed
@portikM portikM deleted the fix/khcp-14152-kalert-slotted-links-styling branch November 26, 2024 21:05
kongponents-bot pushed a commit that referenced this pull request Nov 26, 2024
@semantic-release-bot
chore(release): 9.14.17 [skip ci]
9dd3e03 
## [9.14.17](v9.14.16...v9.14.17) (2024-11-26)

### Bug Fixes

* **kalert:** slotted links default styling [KHCP-14152] ([#2528](#2528)) ([631a287](631a287))
* **ktableview:** row-expanded prop and event [KHCP-14243] ([#2527](#2527)) ([eb92309](eb92309))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.14.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@johncowen johncowen mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@Justineo Justineo Awaiting requested review from Justineo Justineo is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @adamdehaven