Don't make all our links blue

[johncowen]

What happened?

TLDR;

Remove blue styling from in-alert links

---

We've had discussions in the past about anchor link design treatment and I spotted this (#3249 (comment)) today and thought it would be a good opportunity to formalize the decision around that a little by writing it down in an issue. Trying to be a little jovial here 😅 , but essentially putting a big underline underneath the fact that we shouldn't always use blue styling for links

In the past we've had discussions on making sure that all our anchor links in our entire application are blue, because Internet.

An important thing is: Internet != Design i.e. there are other considerations to take into account when deciding these things.

In the above PR for example (a kongponents upgrade) the styling that the authors are trying to enforce is yellow link text on yellow background, because Design.

Even with the above PR applied we still have:

[johncowen]

🤔 I'm just coming back here to take a quick pass at this, and it looks like the Kongponents documents don't have the same styling as in the above screengrab? Weird, oh its because the docs use KExternalLink which turns off the text decoration in the docs 🤔 (I think our usual styling is that we don't ever underline links unless focussed/hovered)

Really not clear whats required here, its looks like the color of links within alerts should be the same color as the alert text but underlined. But we don't use underlines anywhere else (apart from on hover). So if we use the same color its not clear that there is a link in the text 🤔

I think elsewhere we've bolded the text, but kept it the same color (which could be confused for bold text rather than a link)

Not sure what to do here 🤔

[johncowen]

I just checked how other folks are using this, and it does seem like they also have yellow alerts with blue links in them even after Kong/kongponents#2528 (I had to use web inspector to insert a link, so maybe the ::slotted usage means the coloring doesn't work) I guess we might want to keep things as is also 🤷 (i.e. blue with underline on hover)

[johncowen]

I noticed in #3308 that I'm about to merge that there was this change:

Kong/kongponents@84a4e9f

That commit might help things here

[johncowen]

I noticed this seems to now be like this:

Note the difference in the screengrab from the description that the link is no longer blue. We haven't done anything here yet so I'm pretty sure this was a consequence of Kong/kongponents@84a4e9f

Not sure whether we should close this issue or not 🤔 seeing as the above commit causes issues elsewhere:

• fix: upgrade button text color #3317
• fix: globally fix text color of buttons in alerts #3323

(the above PRs fix the issues caused by Kong/kongponents@84a4e9f our side)