-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ktable): remove next page clicked logic [KHCP-13030] #2352
Conversation
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
// this will ensure buttons display the correct state for cases like search | ||
if (!nextPageClicked.value) { | ||
page.value = 1 | ||
} | ||
} else { | ||
offset.value = res.pagination.offset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t quite understand why we updated the offset here and then fixed it in the fetcher. Wouldn’t it make more sense to save res.pagination.offset
into a variable like nextPageOffset
and update the offset only when moving to the next page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13030
Fixes bug when KTable sets page to 1 unexpectedly