fix(ktable): store offset of next page in nextOffset #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Leopoldthecoder
force-pushed
the
fix/store-next-offset
branch
from
dcb06c8 to
69add7e
Compare
adamdehaven
reviewed
Aug 23, 2024
Leopoldthecoder
force-pushed
the
fix/store-next-offset
branch
from
69add7e to
cc17d53
Compare
Leopoldthecoder
force-pushed
the
fix/store-next-offset
branch
from
cc17d53 to
6e05744
Compare
portikM
reviewed
Aug 26, 2024
There was a problem hiding this comment.
These changes look good to me. I've pulled these changes into konnect-ui-apps for sanity check: https://github.com/Kong/konnect-ui-apps/pull/4037. I'll tag a few people to check offset and cursor pagination functionality in different apps just to make sure we don't miss anything.
kongponents-bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
## [9.4.1](v9.4.0...v9.4.1) (2024-08-27) ### Bug Fixes * **ktable:** store offset of next page in nextOffset ([#2355](#2355)) ([bf1821e](bf1821e))
|
🎉 This PR is included in version 9.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes:
nextOffset, so that the originaloffsetref will always equal the offset of the current page.