Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(clustering/sync): clean the logic of sync_once_impl() #14024

Merged
merged 2 commits into from
Dec 16, 2024
Merged

refactor(clustering/sync): clean the logic of sync_once_impl() #14024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b8ed4
refactor(clustering/sync): clean the logic of sync_once_impl()
chronolaw Dec 16, 2024
7526a1f
debug log
chronolaw Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions kong/clustering/services/sync/rpc.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,26 +422,28 @@ function sync_once_impl(premature, retry_count)
return
end

sync_handler()

local latest_notified_version = ngx.shared.kong:get(CLUSTERING_DATA_PLANES_LATEST_VERSION_KEY)
local current_version = tonumber(declarative.get_current_hash()) or 0
sync_handler()

local latest_notified_version = ngx.shared.kong:get(CLUSTERING_DATA_PLANES_LATEST_VERSION_KEY)
if not latest_notified_version then
ngx_log(ngx_DEBUG, "no version notified yet")
return
end

-- retry if the version is not updated
if current_version < latest_notified_version then
retry_count = retry_count or 0
if retry_count > MAX_RETRY then
ngx_log(ngx_ERR, "sync_once retry count exceeded. retry_count: ", retry_count)
return
end
local current_version = tonumber(declarative.get_current_hash()) or 0
if current_version >= latest_notified_version then
ngx_log(ngx_DEBUG, "version already updated")
return
end

return start_sync_once_timer(retry_count + 1)
-- retry if the version is not updated
retry_count = retry_count or 0
if retry_count > MAX_RETRY then
ngx_log(ngx_ERR, "sync_once retry count exceeded. retry_count: ", retry_count)
return
end

return start_sync_once_timer(retry_count + 1)
end


Expand Down
Loading