Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(clustering/sync): clean the logic of sync_once_impl() #14024

Merged
merged 2 commits into from
Dec 16, 2024
Merged

refactor(clustering/sync): clean the logic of sync_once_impl() #14024

merged 2 commits into from
Dec 16, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 16, 2024 •
edited
Loading

Summary

KAG-5944
See #13896 and #13956

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 16, 2024
@chronolaw chronolaw marked this pull request as ready for review December 16, 2024 02:37
StarlightIbuki
StarlightIbuki approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel it necessary but should be fine to merge

@bungle bungle merged commit eeded78 into master Dec 16, 2024
26 checks passed
@bungle bungle deleted the refactor/clean_sync_once_impl branch December 16, 2024 18:30
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@bungle bungle bungle approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @team-gateway-bot @chobits @bungle @StarlightIbuki