Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): split constants into a standalone file #13539

Merged
merged 1 commit into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions spec/details/constants.lua
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@

-- contants used by helpers.lua
local CONSTANTS = {
BIN_PATH = "bin/kong",
TEST_CONF_PATH = os.getenv("KONG_SPEC_TEST_CONF_PATH") or "spec/kong_tests.conf",
CUSTOM_PLUGIN_PATH = "./spec/fixtures/custom_plugins/?.lua",
CUSTOM_VAULT_PATH = "./spec/fixtures/custom_vaults/?.lua;./spec/fixtures/custom_vaults/?/init.lua",
DNS_MOCK_LUA_PATH = "./spec/fixtures/mocks/lua-resty-dns/?.lua",
GO_PLUGIN_PATH = "./spec/fixtures/go",
GRPC_TARGET_SRC_PATH = "./spec/fixtures/grpc/target/",
MOCK_UPSTREAM_PROTOCOL = "http",
MOCK_UPSTREAM_SSL_PROTOCOL = "https",
MOCK_UPSTREAM_HOST = "127.0.0.1",
MOCK_UPSTREAM_HOSTNAME = "localhost",
MOCK_UPSTREAM_PORT = 15555,
MOCK_UPSTREAM_SSL_PORT = 15556,
MOCK_UPSTREAM_STREAM_PORT = 15557,
MOCK_UPSTREAM_STREAM_SSL_PORT = 15558,
GRPCBIN_HOST = os.getenv("KONG_SPEC_TEST_GRPCBIN_HOST") or "localhost",
GRPCBIN_PORT = tonumber(os.getenv("KONG_SPEC_TEST_GRPCBIN_PORT")) or 9000,
GRPCBIN_SSL_PORT = tonumber(os.getenv("KONG_SPEC_TEST_GRPCBIN_SSL_PORT")) or 9001,
MOCK_GRPC_UPSTREAM_PROTO_PATH = "./spec/fixtures/grpc/hello.proto",
ZIPKIN_HOST = os.getenv("KONG_SPEC_TEST_ZIPKIN_HOST") or "localhost",
ZIPKIN_PORT = tonumber(os.getenv("KONG_SPEC_TEST_ZIPKIN_PORT")) or 9411,
OTELCOL_HOST = os.getenv("KONG_SPEC_TEST_OTELCOL_HOST") or "localhost",
OTELCOL_HTTP_PORT = tonumber(os.getenv("KONG_SPEC_TEST_OTELCOL_HTTP_PORT")) or 4318,
OTELCOL_ZPAGES_PORT = tonumber(os.getenv("KONG_SPEC_TEST_OTELCOL_ZPAGES_PORT")) or 55679,
OTELCOL_FILE_EXPORTER_PATH = os.getenv("KONG_SPEC_TEST_OTELCOL_FILE_EXPORTER_PATH") or "./tmp/otel/file_exporter.json",
REDIS_HOST = os.getenv("KONG_SPEC_TEST_REDIS_HOST") or "localhost",
REDIS_PORT = tonumber(os.getenv("KONG_SPEC_TEST_REDIS_PORT") or 6379),
REDIS_SSL_PORT = tonumber(os.getenv("KONG_SPEC_TEST_REDIS_SSL_PORT") or 6380),
REDIS_AUTH_PORT = tonumber(os.getenv("KONG_SPEC_TEST_REDIS_AUTH_PORT") or 6381),
REDIS_SSL_SNI = os.getenv("KONG_SPEC_TEST_REDIS_SSL_SNI") or "test-redis.example.com",
TEST_COVERAGE_MODE = os.getenv("KONG_COVERAGE"),
TEST_COVERAGE_TIMEOUT = 30,
-- consistent with path set in .github/workflows/build_and_test.yml and build/dockerfiles/deb.pongo.Dockerfile
OLD_VERSION_KONG_PATH = os.getenv("KONG_SPEC_TEST_OLD_VERSION_KONG_PATH") or "/usr/local/share/lua/5.1/kong/kong-old",
BLACKHOLE_HOST = "10.255.255.255",
KONG_VERSION = require("kong.meta")._VERSION,
}


return CONSTANTS
39 changes: 1 addition & 38 deletions spec/helpers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -5,44 +5,7 @@
-- @license [Apache 2.0](https://opensource.org/licenses/Apache-2.0)
-- @module spec.helpers

local CONSTANTS = {
BIN_PATH = "bin/kong",
TEST_CONF_PATH = os.getenv("KONG_SPEC_TEST_CONF_PATH") or "spec/kong_tests.conf",
CUSTOM_PLUGIN_PATH = "./spec/fixtures/custom_plugins/?.lua",
CUSTOM_VAULT_PATH = "./spec/fixtures/custom_vaults/?.lua;./spec/fixtures/custom_vaults/?/init.lua",
DNS_MOCK_LUA_PATH = "./spec/fixtures/mocks/lua-resty-dns/?.lua",
GO_PLUGIN_PATH = "./spec/fixtures/go",
GRPC_TARGET_SRC_PATH = "./spec/fixtures/grpc/target/",
MOCK_UPSTREAM_PROTOCOL = "http",
MOCK_UPSTREAM_SSL_PROTOCOL = "https",
MOCK_UPSTREAM_HOST = "127.0.0.1",
MOCK_UPSTREAM_HOSTNAME = "localhost",
MOCK_UPSTREAM_PORT = 15555,
MOCK_UPSTREAM_SSL_PORT = 15556,
MOCK_UPSTREAM_STREAM_PORT = 15557,
MOCK_UPSTREAM_STREAM_SSL_PORT = 15558,
GRPCBIN_HOST = os.getenv("KONG_SPEC_TEST_GRPCBIN_HOST") or "localhost",
GRPCBIN_PORT = tonumber(os.getenv("KONG_SPEC_TEST_GRPCBIN_PORT")) or 9000,
GRPCBIN_SSL_PORT = tonumber(os.getenv("KONG_SPEC_TEST_GRPCBIN_SSL_PORT")) or 9001,
MOCK_GRPC_UPSTREAM_PROTO_PATH = "./spec/fixtures/grpc/hello.proto",
ZIPKIN_HOST = os.getenv("KONG_SPEC_TEST_ZIPKIN_HOST") or "localhost",
ZIPKIN_PORT = tonumber(os.getenv("KONG_SPEC_TEST_ZIPKIN_PORT")) or 9411,
OTELCOL_HOST = os.getenv("KONG_SPEC_TEST_OTELCOL_HOST") or "localhost",
OTELCOL_HTTP_PORT = tonumber(os.getenv("KONG_SPEC_TEST_OTELCOL_HTTP_PORT")) or 4318,
OTELCOL_ZPAGES_PORT = tonumber(os.getenv("KONG_SPEC_TEST_OTELCOL_ZPAGES_PORT")) or 55679,
OTELCOL_FILE_EXPORTER_PATH = os.getenv("KONG_SPEC_TEST_OTELCOL_FILE_EXPORTER_PATH") or "./tmp/otel/file_exporter.json",
REDIS_HOST = os.getenv("KONG_SPEC_TEST_REDIS_HOST") or "localhost",
REDIS_PORT = tonumber(os.getenv("KONG_SPEC_TEST_REDIS_PORT") or 6379),
REDIS_SSL_PORT = tonumber(os.getenv("KONG_SPEC_TEST_REDIS_SSL_PORT") or 6380),
REDIS_AUTH_PORT = tonumber(os.getenv("KONG_SPEC_TEST_REDIS_AUTH_PORT") or 6381),
REDIS_SSL_SNI = os.getenv("KONG_SPEC_TEST_REDIS_SSL_SNI") or "test-redis.example.com",
TEST_COVERAGE_MODE = os.getenv("KONG_COVERAGE"),
TEST_COVERAGE_TIMEOUT = 30,
-- consistent with path set in .github/workflows/build_and_test.yml and build/dockerfiles/deb.pongo.Dockerfile
OLD_VERSION_KONG_PATH = os.getenv("KONG_SPEC_TEST_OLD_VERSION_KONG_PATH") or "/usr/local/share/lua/5.1/kong/kong-old",
BLACKHOLE_HOST = "10.255.255.255",
KONG_VERSION = require("kong.meta")._VERSION,
}
local CONSTANTS = require("spec.details.constants")

local PLUGINS_LIST

Expand Down
Loading