Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): split constants into a standalone file #13539

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Aug 22, 2024

Summary

KAG-5233

It is one of serial refactors of helpers.lua

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Aug 22, 2024
@chronolaw chronolaw changed the title tests(helpers): separate constants to details/constants tests(helpers): move constants to details/constants Aug 22, 2024
@chronolaw chronolaw changed the title tests(helpers): move constants to details/constants tests(helpers): move constants to details/constants Aug 22, 2024
@chronolaw chronolaw marked this pull request as ready for review August 22, 2024 00:42
@chronolaw chronolaw requested a review from windmgc August 22, 2024 00:46
@ADD-SP ADD-SP changed the title tests(helpers): move constants to details/constants tests(helpers): split constants into a standalone file Aug 22, 2024
@ADD-SP ADD-SP merged commit 61e82aa into master Aug 22, 2024
45 checks passed
@ADD-SP ADD-SP deleted the tests/separate_helpers_no1 branch August 22, 2024 03:47
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13539-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13539-to-master-to-upstream
git checkout -b cherry-pick-13539-to-master-to-upstream
ancref=$(git merge-base 38727ba119932bd3f040383a2ae8483d5b1b4257 2e4d22b438b5b7304651b55f4531574c86340072)
git cherry-pick -x $ancref..2e4d22b438b5b7304651b55f4531574c86340072

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 22, 2024
@ADD-SP ADD-SP added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Aug 22, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13539-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13539-to-master-to-upstream
git checkout -b cherry-pick-13539-to-master-to-upstream
ancref=$(git merge-base 38727ba119932bd3f040383a2ae8483d5b1b4257 2e4d22b438b5b7304651b55f4531574c86340072)
git cherry-pick -x $ancref..2e4d22b438b5b7304651b55f4531574c86340072

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 22, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants