-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins): add realm to removed fields #13042
Conversation
4bb59b0
to
357d4d7
Compare
Basic-auth and key-auth added new field "realm" but it was not added to "removed_fields" which breaks backwards compat between new CPs and old DPs. Adding realm to removed fields fixes the issue. KAG-4516
357d4d7
to
00abf10
Compare
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.6.x
git worktree add -d .worktree/backport-13042-to-release/3.6.x origin/release/3.6.x
cd .worktree/backport-13042-to-release/3.6.x
git switch --create backport-13042-to-release/3.6.x
git cherry-pick -x 420b3b6ceb17d84fb84486e0de72635fb4408c45 |
Successfully created backport PR for |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13042-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13042-to-master-to-upstream
git checkout -b cherry-pick-13042-to-master-to-upstream
ancref=$(git merge-base a11338a8f1ac7f869967fc74660380f11b051bb0 00abf103c277a3c74985b40db6647c615fb9efe6)
git cherry-pick -x $ancref..00abf103c277a3c74985b40db6647c615fb9efe6 |
@nowNick I am not sure we need to backport this to 3.6 in CE |
@kikito I think we do. However the backport needs to be tweaked a little because it'll only need |
Summary
Basic-auth and key-auth added new field "realm" but it was not added to "removed_fields" which breaks backwards compat between new CPs and old DPs. Adding realm to removed fields fixes the issue.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4516