-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hmac): add missing www-authenticate headers #11791
Merged
jschmid1
merged 1 commit into
master
from
feat/implement-missing-www-authenticate-headers-hmac
Jun 17, 2024
Merged
fix(hmac): add missing www-authenticate headers #11791
jschmid1
merged 1 commit into
master
from
feat/implement-missing-www-authenticate-headers-hmac
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2023
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
from
October 26, 2023 12:05
c35d2da
to
d87e18b
Compare
3 tasks
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
from
February 15, 2024 12:14
8e37f9a
to
150a3e4
Compare
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
from
April 30, 2024 14:08
150a3e4
to
89c7290
Compare
github-actions
bot
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Apr 30, 2024
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
2 times, most recently
from
April 30, 2024 14:33
e368f65
to
5be3025
Compare
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
2 times, most recently
from
May 9, 2024 12:52
ab1789f
to
cc8e544
Compare
hanshuebner
approved these changes
May 13, 2024
jschmid1
requested changes
May 16, 2024
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
from
May 21, 2024 15:59
cc8e544
to
4c8c799
Compare
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
6 times, most recently
from
May 21, 2024 16:29
d491487
to
630690a
Compare
hanshuebner
approved these changes
May 23, 2024
nowNick
force-pushed
the
feat/implement-missing-www-authenticate-headers-hmac
branch
4 times, most recently
from
June 14, 2024 13:23
2517d20
to
9f85181
Compare
jschmid1
approved these changes
Jun 14, 2024
jschmid1
deleted the
feat/implement-missing-www-authenticate-headers-hmac
branch
June 17, 2024 08:21
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-11791-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-11791-to-master-to-upstream
git checkout -b cherry-pick-11791-to-master-to-upstream
ancref=$(git merge-base 75850071308b6a96e15c6c1ac4e9090c3cb6e4e4 9f851815190654cb49c530b3f6929fa09d827525)
git cherry-pick -x $ancref..9f851815190654cb49c530b3f6929fa09d827525 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Jun 17, 2024
@nowNick please help and manually cherry-pick to ee, thanks. |
nowNick
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/clustering
plugins/hmac-auth
schema-change-noteworthy
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When kong returns
401 Unauthorized
response it should returnWWW-Authenticate
header with proper challenge. HMAC auth was missing this header.Related PRs:
RFCs & Materials
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREFull changelog
WWW-Authenticate
header to hmac 401 responseIssue reference