fix(ci): require correct socket module
#13026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
require 'socket.unix' was causing a different socket module to be loaded If 'socket.unix' was loaded before the `socket` module, it resulted in a different socket implementation to be used, which resulted in failures when trying to access nil fields of the socket object. More info: https://konghq.atlassian.net/browse/KAG-4472
github-actions
bot
added
the
cherry-pick kong-ee
Water-Melon
approved these changes
May 14, 2024
chronolaw
approved these changes
May 14, 2024
bungle
approved these changes
May 14, 2024
|
Successfully created cherry-pick PR for |
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
require 'socket.unix' was causing a different socket module to be loaded If 'socket.unix' was loaded before the `socket` module, it resulted in a different socket implementation to be used, which resulted in failures when trying to access nil fields of the socket object. More info: https://konghq.atlassian.net/browse/KAG-4472 (cherry picked from commit a212d89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
require 'socket.unix' was causing a different socket module to be loaded
If 'socket.unix' was loaded before the
socketmodule, it resulted in a different socket implementation to be used, which resulted in failures when trying to access nil fields of the socket object.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4472