Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tools): update references from kong.tools.utils to kong.tools.table #12487

Merged
merged 3 commits into from
May 17, 2024
Merged

refactor(tools): update references from kong.tools.utils to kong.tools.table #12487

merged 3 commits into from
May 17, 2024

Conversation

Water-Melon
Copy link
Contributor

@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch 5 times, most recently from 7023e3e to 2e46587 Compare February 2, 2024 08:25
chronolaw
chronolaw reviewed Feb 2, 2024
View reviewed changes
kong/pdk/log.lua Outdated Show resolved Hide resolved
kong/tracing/instrumentation.lua Outdated Show resolved Hide resolved
@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch 2 times, most recently from 61165a7 to 52cd6a9 Compare February 2, 2024 14:53
@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch 6 times, most recently from c426cd9 to 69d6203 Compare February 23, 2024 15:04
@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch 2 times, most recently from 0e3ff31 to 6e41202 Compare May 13, 2024 13:44
@Water-Melon
Copy link
Contributor Author

Please merge this PR after merging #13026

@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch 3 times, most recently from 12930be to e9ec88e Compare May 14, 2024 02:09
@Water-Melon
Copy link
Contributor Author

Water-Melon commented May 14, 2024 •
edited
Loading

CI tests after removing most exported functions of kong\tools\table.lua

https://github.com/Kong/kong/actions/runs/9072658583/job/24928507132?pr=12487

@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch 2 times, most recently from c609f82 to fb24e89 Compare May 14, 2024 06:22
@Water-Melon Water-Melon marked this pull request as ready for review May 14, 2024 06:38
@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch from fb24e89 to b54f381 Compare May 15, 2024 03:07
@chronolaw chronolaw changed the title refactor(tools): remove reference of table from utils refactor(tools): updating reference of table from utils May 16, 2024
@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch from b54f381 to 0a27d0e Compare May 16, 2024 06:20
chronolaw
chronolaw reviewed May 16, 2024
View reviewed changes
kong/db/dao/targets.lua Outdated Show resolved Hide resolved
kong/db/schema/others/declarative_config.lua Outdated Show resolved Hide resolved
kong/db/strategies/postgres/connector.lua Outdated Show resolved Hide resolved
kong/plugins/opentelemetry/otlp.lua Outdated Show resolved Hide resolved
spec/01-unit/09-balancer/05-worker_consistency_spec.lua Outdated Show resolved Hide resolved
chronolaw
chronolaw reviewed May 16, 2024
View reviewed changes
spec/01-unit/27-queue_spec.lua Outdated Show resolved Hide resolved
spec/02-integration/03-db/14-dao_spec.lua Outdated Show resolved Hide resolved
spec/02-integration/09-hybrid_mode/01-sync_spec.lua Outdated Show resolved Hide resolved
spec/02-integration/09-hybrid_mode/09-config-compat_spec.lua Outdated Show resolved Hide resolved
spec/03-plugins/15-response-transformer/01-header_transformer_spec.lua Outdated
config = {
subsystem = "http",
},
config = ngx.config,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this comment in the code.

spec/03-plugins/15-response-transformer/01-header_transformer_spec.lua Outdated
ctx = {
KONG_PHASE = 0x00000200,
},
re = ngx.re,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this comment in the code.

spec/03-plugins/23-rate-limiting/06-shorthand_fields_spec.lua Outdated Show resolved Hide resolved
spec/03-plugins/24-response-rate-limiting/06-shorthand_fields_spec.lua Outdated Show resolved Hide resolved
spec/03-plugins/29-acme/07-shorthand_fields_spec.lua Outdated Show resolved Hide resolved
@Water-Melon Water-Melon force-pushed the refactor/remove_reference_of_table_from_utils branch from 5c27fc2 to 3eecb25 Compare May 16, 2024 07:59
@Water-Melon Water-Melon requested a review from chronolaw May 16, 2024 08:00
@Water-Melon Water-Melon changed the title refactor(tools): updating reference of table from utils refactor(tools): update references from kong.tools.utils to kong.tools.table May 17, 2024
@ADD-SP ADD-SP merged commit 20612fb into master May 17, 2024
37 checks passed
@ADD-SP ADD-SP deleted the refactor/remove_reference_of_table_from_utils branch May 17, 2024 08:36
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 17, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 28, 2024
@Kong Kong deleted a comment from team-gateway-bot May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@chronolaw chronolaw chronolaw approved these changes

Assignees

@Water-Melon Water-Melon

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed core/admin-api core/balancer core/clustering core/configuration core/db core/logs core/pdk core/router core/tracing plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer plugins/oauth2 plugins/opentelemetry plugins/request-transformer schema-change-noteworthy size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Water-Melon @chronolaw @ADD-SP @kikito