Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport -> release/3.7.x] fix(migrations): split redis migrations into up and teardown #12989

Merged
merged 1 commit into from
May 7, 2024
Merged

[backport -> release/3.7.x] fix(migrations): split redis migrations into up and teardown #12989

merged 1 commit into from
May 7, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.7.x, triggered by a label in #12983.

Original description

Summary

"UP" phase should only contain non-destructive operations. "TEARDOWN" (or "FINISH") phase should be used to change/delete data.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • N/A There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4419
#12978

@nowNick @github-actions
fix(migrations): split redis migrations into up and teardown
5bb4927 
"UP" phase should only contain non-destructive operations.
"TEARDOWN" (or "FINISH") phase should be used to change/delete data.

KAG-4419

(cherry picked from commit 49aa233)
@team-gateway-bot team-gateway-bot added this to the 3.7.0 milestone May 6, 2024
@team-gateway-bot team-gateway-bot mentioned this pull request May 6, 2024
Merged
3 tasks
kikito
kikito approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@kikito kikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving and merging based on the fact that it is identical to #12983

I know that we are talking about making it more reentrant, but this is still an improvement over what we had

@kikito kikito merged commit 4724af0 into release/3.7.x May 7, 2024
54 checks passed
@kikito kikito deleted the backport-12983-to-release/3.7.x branch May 7, 2024 17:31
@kikito kikito mentioned this pull request May 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowNick nowNick nowNick approved these changes

@kikito kikito kikito approved these changes

Assignees

@nowNick nowNick

@team-gateway-bot team-gateway-bot

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/acme plugins/rate-limiting plugins/response-ratelimiting size/L
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@team-gateway-bot @kikito @nowNick