chore(CI): fix the workflow that comments the docker image on the commit #12693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
ADD-SP
force-pushed
the
add_sp/chore-fix-comment-ci
branch
from
d229c80 to
0f3556e
Compare
ADD-SP
force-pushed
the
add_sp/chore-fix-comment-ci
branch
from
0f3556e to
24f5cf6
Compare
ADD-SP
changed the title
${{ secrets.GITHUB_TOKEN }}
ADD-SP
force-pushed
the
add_sp/chore-fix-comment-ci
branch
from
24f5cf6 to
bb340c4
Compare
ADD-SP
force-pushed
the
add_sp/chore-fix-comment-ci
branch
from
bb340c4 to
d1b02db
Compare
Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`.
The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated,
replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each
run of the workflow, so we don't need to rotate token anymore.
ADD-SP
force-pushed
the
add_sp/chore-fix-comment-ci
branch
from
d1b02db to
6d9e530
Compare
AndyZhang0707
approved these changes
Mar 6, 2024
|
@curiositycasualty could you please give it a look? thanks |
Water-Melon
approved these changes
Mar 7, 2024
ADD-SP
added
backport release/2.8.x
cherry-pick kong-ee
|
Git push to origin failed for release/3.5.x with exitcode 1 |
1 similar comment
|
Git push to origin failed for release/3.5.x with exitcode 1 |
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12693-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12693-to-master-to-upstream
git checkout -b cherry-pick-12693-to-master-to-upstream
ancref=$(git merge-base 7c06064e82a6ac73393aa81ffbb62204dbfa75dd 6d9e530ac2e2687d86c4f2fb0a3f08721c1a3899)
git cherry-pick -x $ancref..6d9e530ac2e2687d86c4f2fb0a3f08721c1a3899 |
|
Git push to origin failed for release/3.6.x with exitcode 1 |
1 similar comment
|
Git push to origin failed for release/3.6.x with exitcode 1 |
|
Git push to origin failed for release/3.6.x with exitcode 1 |
1 similar comment
|
Git push to origin failed for release/3.6.x with exitcode 1 |
|
Git push to origin failed for release/3.3.x with exitcode 1 |
|
Git push to origin failed for release/3.4.x with exitcode 1 |
|
Git push to origin failed for release/3.5.x with exitcode 1 |
|
Git push to origin failed for release/3.6.x with exitcode 1 |
ADD-SP
added a commit
that referenced
this pull request
Mar 8, 2024
…mit (#12693) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
ADD-SP
added a commit
that referenced
this pull request
Mar 8, 2024
…mit (#12693) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
ADD-SP
added a commit
that referenced
this pull request
Mar 8, 2024
…mit (#12693) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
ADD-SP
added a commit
that referenced
this pull request
Mar 8, 2024
…mit (#12693) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
ADD-SP
added a commit
that referenced
this pull request
Mar 8, 2024
…mit (#12693) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
flrgh
pushed a commit
that referenced
this pull request
Mar 12, 2024
…mit (#12693) (#12707) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
flrgh
pushed a commit
that referenced
this pull request
Mar 12, 2024
…mit (#12693) (#12708) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
flrgh
pushed a commit
that referenced
this pull request
Mar 12, 2024
…mit (#12693) (#12709) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
flrgh
pushed a commit
that referenced
this pull request
Mar 12, 2024
…mit (#12693) (#12710) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
flrgh
pushed a commit
that referenced
this pull request
Mar 12, 2024
…mit (#12693) (#12711) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
AndyZhang0707
pushed a commit
that referenced
this pull request
Jun 21, 2024
…mit (#12693) (#12711) Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`. The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated, replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each run of the workflow, so we don't need to rotate token anymore.
locao
pushed a commit
that referenced
this pull request
Jun 22, 2024
Co-authored-by: Zachary Hu <[email protected]> Co-authored-by: Niklaus Schen <[email protected]> Co-authored-by: Zhongwei Yao <[email protected]> Co-authored-by: samugi <[email protected]> Co-authored-by: Water-Melon <[email protected]> Co-authored-by: Michael Martin <[email protected]> Co-authored-by: Kong Team Gateway Bot <[email protected]> Co-authored-by: Zachary Hu <[email protected]> Co-authored-by: Qi <[email protected]> Co-authored-by: Mayo <[email protected]> Co-authored-by: Wangchong Zhou <[email protected]> Co-authored-by: Harry <[email protected]> Co-authored-by: Datong Sun <[email protected]> Co-authored-by: Vinicius Mignot <[email protected]> fix directory when stop_kong called (#12713) fix directory when stop_kong called (#12691) fix the workflow that comments the docker image on the commit (#12693) (#12711) fix(ci): replace "cpio" rpm extraction (#13233) (#13263) fix label-check test (#9717)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
${{ secrets.GHA_COMMENT_TOKEN }}needs to be manually rotated, replacing it by${{ secrets.GITHUB_TOKEN }}, which is generated by each run of the workflow, so we don't need to rotate tokens anymore.${{ secrets.GITHUB_TOKEN }}Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdKAG-4021