Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport release/2.8.x] chore(CI): fix the workflow that comments the docker image on the commit #12711

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Mar 8, 2024

Backport #12693

KAG-4021

…mit (#12693)

Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`.

The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated,
replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each
run of the workflow, so we don't need to rotate token anymore.
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Mar 8, 2024
@ADD-SP ADD-SP changed the title Backport release/3.3.x] chore(CI): fix the workflow that comments the docker image on the commit Backport release/2.7.x] chore(CI): fix the workflow that comments the docker image on the commit Mar 8, 2024
@ADD-SP ADD-SP changed the title Backport release/2.7.x] chore(CI): fix the workflow that comments the docker image on the commit Backport release/2.8.x] chore(CI): fix the workflow that comments the docker image on the commit Mar 8, 2024
@ADD-SP ADD-SP changed the title Backport release/2.8.x] chore(CI): fix the workflow that comments the docker image on the commit [Backport release/2.8.x] chore(CI): fix the workflow that comments the docker image on the commit Mar 8, 2024
@ADD-SP ADD-SP changed the title [Backport release/2.8.x] chore(CI): fix the workflow that comments the docker image on the commit [backport release/2.8.x] chore(CI): fix the workflow that comments the docker image on the commit Mar 8, 2024
@ADD-SP ADD-SP marked this pull request as ready for review March 8, 2024 02:03
@flrgh flrgh merged commit 697d27f into release/2.8.x Mar 12, 2024
30 checks passed
@flrgh flrgh deleted the add_sp/backport-chore-fix-comment-ci-28x branch March 12, 2024 17:50
AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
…mit (#12693) (#12711)

Replace `${{ secrets.GHA_COMMENT_TOKEN }}` with `${{ secrets.GITHUB_TOKEN }}`.

The `${{ secrets.GHA_COMMENT_TOKEN }}` needs to be manually rotated,
replacing it by `${{ secrets.GITHUB_TOKEN }}`, which is generated by each
run of the workflow, so we don't need to rotate token anymore.
locao pushed a commit that referenced this pull request Jun 22, 2024
Co-authored-by: Zachary Hu <[email protected]>
Co-authored-by: Niklaus Schen <[email protected]>
Co-authored-by: Zhongwei Yao <[email protected]>
Co-authored-by: samugi <[email protected]>
Co-authored-by: Water-Melon <[email protected]>
Co-authored-by: Michael Martin <[email protected]>
Co-authored-by: Kong Team Gateway Bot <[email protected]>
Co-authored-by: Zachary Hu <[email protected]>
Co-authored-by: Qi <[email protected]>
Co-authored-by: Mayo <[email protected]>
Co-authored-by: Wangchong Zhou <[email protected]>
Co-authored-by: Harry <[email protected]>
Co-authored-by: Datong Sun <[email protected]>
Co-authored-by: Vinicius Mignot <[email protected]>
fix directory when stop_kong called (#12713)
fix directory when stop_kong called (#12691)
fix the workflow that comments the docker image on the commit (#12693) (#12711)
fix(ci): replace "cpio" rpm extraction (#13233) (#13263)
fix label-check test (#9717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants