Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): add missing www-authenticate headers #11759

Closed
wants to merge 1 commit into from
Closed

fix(auth): add missing www-authenticate headers #11759

wants to merge 1 commit into from

Conversation

nowNick
Copy link
Contributor

@nowNick nowNick commented Oct 13, 2023 •
edited
Loading

This PR is going to be closed in favor of plugin specific PRs like:

@nowNick nowNick force-pushed the feat/implement-missing-www-authenticate-headers branch from 980b665 to 27e2513 Compare October 13, 2023 14:59
@nowNick nowNick force-pushed the feat/implement-missing-www-authenticate-headers branch 6 times, most recently from 143a0d9 to 945cafd Compare October 19, 2023 10:00
@nowNick
fix(hmac): add missing www-authenticate headers
c35d2da 
When serve returns 401 Unauthorized response it should
return WWW-Authenticate header as well with proper challenge.
HMAC auth was missing this header.

Fix: #7772
KAG-321
@nowNick nowNick force-pushed the feat/implement-missing-www-authenticate-headers branch from 945cafd to c35d2da Compare October 19, 2023 10:02
@nowNick nowNick closed this Oct 19, 2023
@nowNick nowNick deleted the feat/implement-missing-www-authenticate-headers branch October 19, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nowNick nowNick

Labels
plugins/hmac-auth size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nowNick