Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ci): integrate upgrade tests into build_and_test.yml #11783

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

hanshuebner
Copy link
Contributor

@hanshuebner hanshuebner commented Oct 18, 2023

Summary

Previously, the upgrade tests were in a standalone workflow and used an incorrect container image as the upgrade target version. With this PR, the tests are integrated into the main build/test workflow and make use of the same container image as pongo, which is built from the PR's branch.

Adapted from https://github.com/Kong/kong-ee/pull/6853 - In EE, we already build a docker image for testing with Pongo, so it made sense to piggy-back the upgrade testing onto that. In CE, we don't have that, so the image is built specifically for the upgrade test.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-2804

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Oct 18, 2023
@hanshuebner hanshuebner force-pushed the fix/kag-2804-integrate-upgrade-tests branch 3 times, most recently from 145756a to f1b752a Compare October 18, 2023 16:07
@chronolaw chronolaw changed the title chore(tests): integrate upgrade tests into build_and_test.yml tests(ci): integrate upgrade tests into build_and_test.yml Oct 19, 2023
@hanshuebner hanshuebner force-pushed the fix/kag-2804-integrate-upgrade-tests branch 6 times, most recently from 9a4d2cd to 8af90f0 Compare October 19, 2023 13:45
@pull-request-size pull-request-size bot added size/S and removed size/L labels Oct 19, 2023
@hanshuebner hanshuebner force-pushed the fix/kag-2804-integrate-upgrade-tests branch 3 times, most recently from dd29933 to 0f1671a Compare October 19, 2023 14:47
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 19, 2023
@hanshuebner hanshuebner force-pushed the fix/kag-2804-integrate-upgrade-tests branch 2 times, most recently from 7b0194e to 296d32b Compare October 19, 2023 15:13
@hanshuebner hanshuebner marked this pull request as ready for review October 19, 2023 15:14
@flrgh flrgh force-pushed the fix/kag-2804-integrate-upgrade-tests branch from 296d32b to dab6c2b Compare October 19, 2023 18:03
@hanshuebner hanshuebner force-pushed the fix/kag-2804-integrate-upgrade-tests branch from dab6c2b to 19c8f4f Compare October 20, 2023 07:30
@hanshuebner hanshuebner merged commit 74bd113 into master Oct 20, 2023
@hanshuebner hanshuebner deleted the fix/kag-2804-integrate-upgrade-tests branch October 20, 2023 08:17
@outsinre
Copy link
Contributor

outsinre commented Oct 20, 2023

This is cherry-picked from EE 2 CE. No need to do CE2EE merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants