Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): trigger upgrade tests when changing kong/templates files #11782

Closed
wants to merge 1 commit into from

Conversation

AndyZhang0707
Copy link
Collaborator

@AndyZhang0707 AndyZhang0707 commented Oct 18, 2023

Summary

Originally changes to the kong/templates files didn't trigger the upgrade test in the PR build, however, this leads an issue that it may cause the master failure after the PR is merged. This change is to trigger the upgrade test workflow in the PR's CI so that we could identify any potential migration issue earlier during the development.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/templates chore Not part of the core functionality of kong, but still needed labels Oct 18, 2023
@AndyZhang0707 AndyZhang0707 requested a review from ADD-SP October 18, 2023 09:34
@AndyZhang0707
Copy link
Collaborator Author

Here is test run which triggered the migration test https://github.com/Kong/kong/actions/runs/6558380369/job/17811824375?pr=11782

@AndyZhang0707 AndyZhang0707 force-pushed the fix/trigger-upgrade-test branch from 509b80c to 4c03bff Compare October 18, 2023 09:38
@AndyZhang0707 AndyZhang0707 marked this pull request as ready for review October 18, 2023 10:05
@chronolaw
Copy link
Contributor

Due to #11783, we should close this PR.

@chronolaw chronolaw closed this Oct 19, 2023
@chronolaw chronolaw deleted the fix/trigger-upgrade-test branch October 19, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants