Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugins/jwt): use encode_base64url in resty.core #11569

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 14, 2023

Summary

lua-resty-core provides two functions base64.encode_base64url() and base64.decode_base64url(),
Which have the same effect as our Lua functions.

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • use base64.encode_base64url and base64.decode_base64url
  • optimize table insert

Issue reference

Fix #[issue number]

@chronolaw chronolaw changed the title refactor(plugis/jwt): use encode_base64url in resty.core refactor(plugins/jwt): use encode_base64url in resty.core Sep 14, 2023
@chronolaw chronolaw marked this pull request as ready for review September 14, 2023 08:29
@windmgc windmgc merged commit 7a32972 into master Sep 19, 2023
25 checks passed
@windmgc windmgc deleted the refactor/use_encode_base64url_in_jwt branch September 19, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants