Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugins/oauth): use encode_base64url in resty.core #12069

Closed
wants to merge 6 commits into from

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 21, 2023

Summary

Same like #11569

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw
Copy link
Contributor Author

Plugin: oauth2 [#postgres] access OAuth2 Access Token succeeds when code challenge contains + or / characters
spec/03-plugins/25-oauth2/03-access_spec.lua:2507: Invalid response status code.
Status expected:
(number) 200
Status received:
(number) [400](https://github.com/Kong/kong/actions/runs/6939962713/job/18878143542?pr=12069#step:16:401)
Body:
(string) '{"error":"invalid_grant","error_description":"Invalid code"}'
200

But I have no time to solve it.

@chronolaw chronolaw closed this Nov 21, 2023
@chronolaw chronolaw deleted the refactor/use_encode_base64url_in_resty_core branch November 21, 2023 06:36
@chronolaw chronolaw restored the refactor/use_encode_base64url_in_resty_core branch November 21, 2023 08:51
@chronolaw chronolaw reopened this Nov 21, 2023
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 21, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 21, 2023
@chronolaw
Copy link
Contributor Author

Still got ci test failure.

@chronolaw chronolaw closed this Nov 21, 2023
@chronolaw chronolaw deleted the refactor/use_encode_base64url_in_resty_core branch November 21, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant