Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/default add look up tags REBASED #31

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

AntoineJac
Copy link
Collaborator

Linked to the PR:
Kong/deck#1124

Description:
Please see Jira: https://konghq.atlassian.net/browse/APIOPS-100

This branch will add a new feature to pass a new lookup_tags in the _info section. It will allow the local state to retrieve the the corresponding entities in Kong.

_info: 
  default_lookup_tags:
    consumers:
    - test
    - test3
    - test2

@teb510
Copy link

teb510 commented Jan 3, 2024

@GGabriele could you review this guy please? then we can merge the 'global consumer' PR after this one.

pkg/dump/dump.go Outdated
@@ -28,6 +28,10 @@ type Config struct {
// tags.
SelectorTags []string

// LookUpSelectorTagsConsumers can be used to lookup entities using other
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please expand on this? As it is, it's not immediate how this can be used and when.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GGabriele for instance CMA is creating consumers using a pipeline 1 with tag "consumers_global".
They have a pipeline 2 for services (tag: serviceName) that could for instance set up "rate-limting" plugins on different consumers, as these consumers are not part of the sync for this pipeline it will fail.

Using a LookUpSelectorTagsConsumers you can specify deck to check if the consumers exist on a different tag

Please let me know if you have other questions

Copy link
Collaborator

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineJac I added a small comment, but other than that this LGTM!

@AntoineJac AntoineJac force-pushed the feat/add-default-look-up-tags-rebase branch from dcaeafe to 266dee8 Compare January 15, 2024 08:22
@AntoineJac AntoineJac merged commit 14fe4d3 into main Jan 15, 2024
39 checks passed
@AntoineJac AntoineJac deleted the feat/add-default-look-up-tags-rebase branch January 15, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants