-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/default add look up tags REBASED #31
Conversation
@GGabriele could you review this guy please? then we can merge the 'global consumer' PR after this one. |
pkg/dump/dump.go
Outdated
@@ -28,6 +28,10 @@ type Config struct { | |||
// tags. | |||
SelectorTags []string | |||
|
|||
// LookUpSelectorTagsConsumers can be used to lookup entities using other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please expand on this? As it is, it's not immediate how this can be used and when.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GGabriele for instance CMA is creating consumers using a pipeline 1 with tag "consumers_global".
They have a pipeline 2 for services (tag: serviceName) that could for instance set up "rate-limting" plugins on different consumers, as these consumers are not part of the sync for this pipeline it will fail.
Using a LookUpSelectorTagsConsumers you can specify deck to check if the consumers exist on a different tag
Please let me know if you have other questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineJac I added a small comment, but other than that this LGTM!
dcaeafe
to
266dee8
Compare
Linked to the PR:
Kong/deck#1124
Description:
Please see Jira: https://konghq.atlassian.net/browse/APIOPS-100
This branch will add a new feature to pass a new lookup_tags in the _info section. It will allow the local state to retrieve the the corresponding entities in Kong.