Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/default add look up tags REBASED #1124

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Conversation

AntoineJac
Copy link
Collaborator

@AntoineJac AntoineJac commented Nov 30, 2023

Linked to the PR:
Kong/go-database-reconciler#31

Description:
Please see Jira: https://konghq.atlassian.net/browse/APIOPS-100

This branch will add a new feature to pass a new lookup_tags in the _info section. It will allow the local state to retrieve the the corresponding entities in Kong.

_info: 
  default_lookup_tags:
    consumers:
    - test
    - test3
    - test2

@AntoineJac AntoineJac requested a review from a team November 30, 2023 21:37
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AntoineJac AntoineJac changed the title add lookup tag Feat/default add look up tags #1097 Nov 30, 2023
@AntoineJac AntoineJac changed the title Feat/default add look up tags #1097 Feat/default add look up tags Nov 30, 2023
@AntoineJac AntoineJac force-pushed the feat/add-default-look-up-tags branch from 5eceb02 to fae6d82 Compare December 23, 2023 11:22
@AntoineJac AntoineJac changed the title Feat/default add look up tags Feat/default add look up tags REBASED Dec 23, 2023
@AntoineJac AntoineJac force-pushed the feat/add-default-look-up-tags branch from fae6d82 to 19d0c37 Compare January 15, 2024 09:12
@codecov-commenter
Copy link

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (6146f3a) 0.00% compared to head (d674e68) 5.83%.

Files Patch % Lines
cmd/common.go 0.00% 25 Missing ⚠️
cmd/gateway_validate.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           main   #1124      +/-   ##
=======================================
+ Coverage      0   5.83%   +5.83%     
=======================================
  Files         0      31      +31     
  Lines         0    3189    +3189     
=======================================
+ Hits          0     186     +186     
- Misses        0    2993    +2993     
- Partials      0      10      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntoineJac AntoineJac merged commit c5d98fe into main Jan 15, 2024
35 checks passed
@AntoineJac AntoineJac deleted the feat/add-default-look-up-tags branch January 15, 2024 10:34
AntoineJac added a commit that referenced this pull request Jan 23, 2024
* add lookup tag

* new version go database reconciler

* new version go database reconciler

* new version go database reconciler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants