Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/default-lookup-services-consumerGroups #130

Merged
merged 14 commits into from
Sep 18, 2024

Conversation

AntoineJac
Copy link
Collaborator

@AntoineJac AntoineJac commented Aug 21, 2024

Summary

feat/default-lookup-services-consumerGroups
Similar changes to: #44

PR: https://konghq.atlassian.net/browse/FTI-6181

Related to Kong/deck#1367

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@GGabriele GGabriele requested a review from Prashansa-K August 27, 2024 11:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 40 lines in your changes missing coverage. Please review.

Project coverage is 29.88%. Comparing base (da91179) to head (b49f6a2).

Files with missing lines Patch % Lines
pkg/dump/dump.go 0.00% 24 Missing ⚠️
pkg/file/builder.go 31.25% 10 Missing and 1 partial ⚠️
pkg/file/reader.go 0.00% 2 Missing and 2 partials ⚠️
pkg/file/readfile.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   29.95%   29.88%   -0.07%     
==========================================
  Files         106      106              
  Lines       12589    12631      +42     
==========================================
+ Hits         3771     3775       +4     
- Misses       8358     8393      +35     
- Partials      460      463       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Prashansa-K
Prashansa-K previously approved these changes Sep 3, 2024
@AntoineJac AntoineJac force-pushed the feat/default-lookup-services-consumerGroups branch from 7b2a02e to b5b73ab Compare September 9, 2024 13:03
Prashansa-K
Prashansa-K previously approved these changes Sep 10, 2024
mheap
mheap previously approved these changes Sep 13, 2024
@AntoineJac AntoineJac enabled auto-merge (squash) September 13, 2024 08:24
@mheap mheap requested a review from Prashansa-K September 13, 2024 08:30
pkg/dump/dump.go Outdated Show resolved Hide resolved
pkg/dump/dump.go Outdated Show resolved Hide resolved
pkg/file/builder.go Outdated Show resolved Hide resolved
pkg/file/builder.go Show resolved Hide resolved
@AntoineJac AntoineJac merged commit 01fa2d0 into main Sep 18, 2024
18 checks passed
@AntoineJac AntoineJac deleted the feat/default-lookup-services-consumerGroups branch September 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants