-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/default lookup services consumer groups #1367
Conversation
@AntoineJac Could you take a look at the failed checks and conflicts here please? |
@Prashansa-K , the PR need first to be merged before: Kong/go-database-reconciler#130 Also I have not included yet the tests to this PR. |
@AntoineJac Could you now merge the other PR and add the required tests here please? The other PR is approved. |
For info test will fail untils this PR is merged: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
- Coverage 29.52% 29.16% -0.36%
==========================================
Files 59 59
Lines 5138 5211 +73
==========================================
+ Hits 1517 1520 +3
- Misses 3512 3583 +71
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. |
Feat/default lookup services consumer groups
Require: Kong/go-database-reconciler#130
Similar changes to: #1173
PR: https://konghq.atlassian.net/browse/FTI-6181
https://konghq.atlassian.net/browse/FTI-6185