Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/default lookup services consumer groups #1367

Merged
merged 23 commits into from
Sep 19, 2024

Conversation

AntoineJac
Copy link
Collaborator

@AntoineJac AntoineJac commented Aug 21, 2024

Feat/default lookup services consumer groups

Require: Kong/go-database-reconciler#130

Similar changes to: #1173

PR: https://konghq.atlassian.net/browse/FTI-6181

@GGabriele GGabriele requested a review from Prashansa-K August 27, 2024 11:34
@Prashansa-K
Copy link
Contributor

@AntoineJac Could you take a look at the failed checks and conflicts here please?

@AntoineJac
Copy link
Collaborator Author

@Prashansa-K , the PR need first to be merged before: Kong/go-database-reconciler#130

Also I have not included yet the tests to this PR.

@Prashansa-K
Copy link
Contributor

@AntoineJac Could you now merge the other PR and add the required tests here please? The other PR is approved.

@AntoineJac
Copy link
Collaborator Author

For info test will fail untils this PR is merged:
Kong/go-database-reconciler#130

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.

Project coverage is 29.16%. Comparing base (74b1859) to head (26f429c).

Files with missing lines Patch % Lines
cmd/common.go 0.00% 50 Missing ⚠️
cmd/gateway_validate.go 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
- Coverage   29.52%   29.16%   -0.36%     
==========================================
  Files          59       59              
  Lines        5138     5211      +73     
==========================================
+ Hits         1517     1520       +3     
- Misses       3512     3583      +71     
+ Partials      109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mheap mheap merged commit a50b695 into main Sep 19, 2024
19 checks passed
@mheap mheap deleted the feat/default-lookup-services-consumerGroups branch September 19, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants