Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(konnect): handle KongRoute conflict on creation #752

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 17, 2024

What this PR does / why we need it:

Follow up on #749 for KongRoute.

@pmalek pmalek added this to the KGO v1.4.x milestone Oct 17, 2024
@pmalek pmalek self-assigned this Oct 17, 2024
@pmalek pmalek requested a review from a team as a code owner October 17, 2024 18:22
@pmalek pmalek force-pushed the konnect-uid-adoption-routes branch 2 times, most recently from 2b6fbdb to c87d1dd Compare October 17, 2024 19:01
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, some minor comments remaining.

controller/konnect/ops/ops.go Outdated Show resolved Hide resolved
controller/konnect/ops/ops.go Outdated Show resolved Hide resolved
@pmalek pmalek requested a review from randmonkey October 18, 2024 09:31
@pmalek pmalek force-pushed the konnect-uid-adoption-routes branch from fe5114a to 009be32 Compare October 18, 2024 09:57
@pmalek pmalek merged commit dcfe0ce into main Oct 18, 2024
21 checks passed
@pmalek pmalek deleted the konnect-uid-adoption-routes branch October 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants