Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(konnect): handle KongUpstream conflict on creation #756

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 18, 2024

What this PR does / why we need it:

Follow up on #752 for KongUpstream.

This PR also adds a separate type CantPerformOperationWithoutControlPlaneIDError that's reused by all entities having a CP ref, when the CP ID is not set.

@pmalek pmalek added this to the KGO v1.4.x milestone Oct 18, 2024
@pmalek pmalek self-assigned this Oct 18, 2024
@pmalek pmalek requested a review from a team as a code owner October 18, 2024 14:06
@pmalek pmalek changed the title fix: handle KongUpstream conflict on creation fix(konnect): handle KongUpstream conflict on creation Oct 18, 2024
@pmalek pmalek force-pushed the konnect-uid-adoption-upstream branch from 05d1ba6 to d8d518f Compare October 18, 2024 14:31
@pmalek pmalek enabled auto-merge (squash) October 18, 2024 14:32
@pmalek pmalek force-pushed the konnect-uid-adoption-upstream branch from ff0fd23 to 9c4ea31 Compare October 18, 2024 14:42
@pmalek pmalek force-pushed the konnect-uid-adoption-upstream branch 2 times, most recently from 559ef43 to 3ac131d Compare October 18, 2024 15:09
@pmalek pmalek force-pushed the konnect-uid-adoption-upstream branch from 3ac131d to 65cb150 Compare October 18, 2024 15:26
@pmalek pmalek merged commit 9e8f425 into main Oct 18, 2024
21 checks passed
@pmalek pmalek deleted the konnect-uid-adoption-upstream branch October 18, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants