perf(cir): special treatment for single-predicate expression #988
Annotations
13 warnings
Rust Fmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Lua Check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
empty line after doc comment:
src/ffi/expression.rs#L145
warning: empty line after doc comment
--> src/ffi/expression.rs:145:1
|
145 | / /// - `errbuf_len` must be a valid pointer for reading and writing `size_of::<usize>()` bytes and properly aligned.
146 | |
| |_
147 | #[no_mangle]
148 | / pub unsafe extern "C" fn expression_validate(
149 | | atc: *const u8,
150 | | schema: &Schema,
151 | | fields_buf: *mut u8,
... |
156 | | errbuf_len: *mut usize,
157 | | ) -> i64 {
| |________- the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
unneeded `return` statement:
src/parser.rs#L160
warning: unneeded `return` statement
--> src/parser.rs:160:5
|
160 | return pair.as_str().chars().next().unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-W clippy::needless-return` implied by `-W clippy::style`
= help: to override `-W clippy::style` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
160 - return pair.as_str().chars().next().unwrap();
160 + pair.as_str().chars().next().unwrap()
|
|
empty line after doc comment:
src/parser.rs#L17
warning: empty line after doc comment
--> src/parser.rs:17:1
|
17 | / /// cbindgen:ignore
18 | | // Bug: https://github.com/eqrion/cbindgen/issues/286
19 | |
| |_
20 | trait IntoParseResult<T> {
| ------------------------ the comment documents this trait
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `-W clippy::empty-line-after-doc-comments` implied by `-W clippy::suspicious`
= help: to override `-W clippy::suspicious` add `#[allow(clippy::empty_line_after_doc_comments)]`
= help: if the empty line is unintentional remove it
help: if the doc comment should not document `IntoParseResult` comment it out
|
17 | // /// cbindgen:ignore
| ++
|
Rust Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Clippy
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Clippy
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Clippy
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|