perf(cir): special treatment for single-predicate expression #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oyami-Srk
force-pushed
the
1.7.0-fix-attempt
branch
from
b030579 to
2c89705
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Oyami-Srk
force-pushed
the
1.7.0-fix-attempt
branch
from
2c89705 to
68492a9
Compare
Oyami-Srk
force-pushed
the
1.7.0-fix-attempt
branch
from
68492a9 to
b6179f2
Compare
Oyami-Srk
commented
Dec 30, 2024
| Self::new() | ||
| } | ||
| pub enum CirProgram { | ||
| Instructions(Vec<CirInstruction>), |
There was a problem hiding this comment.
Should we use boxed slice instead Vec to emphasize that instructions won't grow over time?
xianghai2
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAG-6094