Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Finder 36.11 10A SPDT relay symbol #1998

Merged
merged 2 commits into from
Apr 11, 2020

Conversation

chschlue
Copy link
Contributor

@chschlue chschlue commented Jul 22, 2019

Add Finder 36.11 10A SPDT relay symbol

Datasheet: https://gfinder.findernet.com/public/attachments/36/EN/S36EN.pdf
Footprint: KiCad/kicad-footprints#1728

Violating S5.1: Pending footprint

3611sym


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@chschlue chschlue marked this pull request as ready for review July 22, 2019 07:12
@antoniovazquezblanco antoniovazquezblanco added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 22, 2019
@antoniovazquezblanco
Copy link
Collaborator

Depends on KiCad/kicad-website#418

@antoniovazquezblanco antoniovazquezblanco added the Pending KLC issue This depends on a open KLC issue label Jul 22, 2019
@chschlue
Copy link
Contributor Author

@evanshultz
This poor symbol feels very sad and lonely. It wants to join its brother KiCad/kicad-footprints#1728

@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage myfreescalewebpage removed Pending KLC issue This depends on a open KLC issue Pending reviewer A pull request waiting for a reviewer labels Apr 11, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Apr 11, 2020
@myfreescalewebpage
Copy link
Collaborator

Not sure the conclusion about relay naming will be done soon, and this is only 1 symbol in the entire library. Will not be an important work to change this one later (v6?). Merging now.

@myfreescalewebpage myfreescalewebpage merged commit e82e330 into KiCad:master Apr 11, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants