-
Notifications
You must be signed in to change notification settings - Fork 744
Relay: Improved the Finder 36.11 relays. #1278
base: master
Are you sure you want to change the base?
Conversation
- Added Finder 36.11-4001 SPDT relay. - Changed footprint of Finder 36.11-4301 relay (was completely wrong). - Fixed the datasheet of the 36.11-4001 relay (used to point to 4011 datasheet).
Hi @mgottschlag , thanks for contributing, A few comments I have during my review: FINDER-32.21-x300
FINDER-36.11-4301
FINDER-36.11-4001
Need to wait for the footprints to merge this PR. Cheers, |
@mgottschlag ping! |
@mgottschlag @myfreescalewebpage Also, -4001 is out of production. |
Thanks for the answer. However, all FINDER-36.11 are not the same so #1998 seems invalid.... This PR seems better. But maybe I miss something ? |
I think there's just the double throw variant 36.11-4011 left. KiCad/kicad-website#418 is still open anyway. |
Merging this would likely break my PR at #1984. I would love if my PR could be merged and I'll incorporate changes here into my PR if that makes things easier. I also reviewed the footprint mentioned above. |
@evanshultz according to your previous comment I suggest we should reject this PR. What do you think ? |
@myfreescalewebpage |
I do not suggest to remove it from the library. I just ask if this PR should be rejected if it breaks #1984 enhancements? |
#1984 was already merged. And I didn't incorporate the changes here since I never got a response. I don't see anything wrong with the concept of this PR, and while -4001 may be out of production surely there are compatible relays available on the market. These relay symbols are more complex than they need to be, but if they are updated to the style from #1984 I'm OK merging. |
OK, just some few fix to do. @mgottschlag can you fix the issues in my previous comment (#1278 (comment)) ? Thanks. |
No news of the original author, indicate the PR is abandoned. |
datasheet).
Intended as a fix for #1275.
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
https://www.finder-relais.net/en/finder-relays-series-36.pdf
(they don't... see the footprint PR)
Relay: Added Finder 36.11 footprints (copied from Sanyou relays). kicad-footprints#1181