Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Relay: Improved the Finder 36.11 relays. #1278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgottschlag
Copy link
Contributor

@mgottschlag mgottschlag commented Dec 18, 2018

  • Added Finder 36.11-4001 SPDT relay.
  • Changed footprint of Finder 36.11-4301 relay (was completely wrong).
  • Fixed the datasheet of the 36.11-4001 relay (used to point to 4011
    datasheet).
  • Fixed the properties of RM50-xx21.

Intended as a fix for #1275.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

- Added Finder 36.11-4001 SPDT relay.
- Changed footprint of Finder 36.11-4301 relay (was completely wrong).
- Fixed the datasheet of the 36.11-4001 relay (used to point to 4011
  datasheet).
@antoniovazquezblanco antoniovazquezblanco added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Dec 18, 2018
@antoniovazquezblanco antoniovazquezblanco added this to the Backlog milestone Dec 18, 2018
@antoniovazquezblanco antoniovazquezblanco removed this from the Backlog milestone Apr 17, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this Apr 20, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Apr 20, 2019
@myfreescalewebpage
Copy link
Collaborator

Hi @mgottschlag , thanks for contributing,

A few comments I have during my review:

FINDER-32.21-x300

  • Can you fix the travis error about pin name position offset at the same time (should be 20mil) ?

FINDER-36.11-4301

  • Can you fix the travis error about pin name position offset (should be 20mil) ?
  • RM50-xx21 has not exactly the same size, the footprint should be defined too and associated correclty.

FINDER-36.11-4001

  • Can you fix the travis error about pin name position offset (should be 20mil) ?

Need to wait for the footprints to merge this PR.

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Apr 20, 2019
@myfreescalewebpage
Copy link
Collaborator

@mgottschlag ping!

@chschlue
Copy link
Contributor

@mgottschlag @myfreescalewebpage
Must have missed this when I opened #1998 and KiCad/kicad-footprints#1728

Also, -4001 is out of production.

@myfreescalewebpage
Copy link
Collaborator

Thanks for the answer. However, all FINDER-36.11 are not the same so #1998 seems invalid.... This PR seems better. But maybe I miss something ?

@chschlue
Copy link
Contributor

I think there's just the double throw variant 36.11-4011 left.
Not sure about your policy regarding extinct parts.

KiCad/kicad-website#418 is still open anyway.

@evanshultz
Copy link
Collaborator

Merging this would likely break my PR at #1984. I would love if my PR could be merged and I'll incorporate changes here into my PR if that makes things easier.

I also reviewed the footprint mentioned above.

@myfreescalewebpage
Copy link
Collaborator

@evanshultz according to your previous comment I suggest we should reject this PR. What do you think ?

@evanshultz
Copy link
Collaborator

@myfreescalewebpage
I also see that -4301 was withdrawn from the market, but why does it need to be removed from the library? Are you saying to close this and continue on with #1998?

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Dec 15, 2019

I also see that -4301 was withdrawn from the market, but why does it need to be removed from the library

I do not suggest to remove it from the library.

I just ask if this PR should be rejected if it breaks #1984 enhancements?

@evanshultz
Copy link
Collaborator

#1984 was already merged. And I didn't incorporate the changes here since I never got a response.

I don't see anything wrong with the concept of this PR, and while -4001 may be out of production surely there are compatible relays available on the market. These relay symbols are more complex than they need to be, but if they are updated to the style from #1984 I'm OK merging.

@myfreescalewebpage
Copy link
Collaborator

OK, just some few fix to do. @mgottschlag can you fix the issues in my previous comment (#1278 (comment)) ? Thanks.

@myfreescalewebpage
Copy link
Collaborator

No news of the original author, indicate the PR is abandoned.

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Enhancement Improves existing symbol in the library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants