-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeplerCBVCorrector can now take a KeplerLightCurve Object #168
Open
christinahedges
wants to merge
7
commits into
KeplerGO:master
Choose a base branch
from
christinahedges:cbv-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e96b4f6
Merge branch 'master' of https://github.com/keplerGO/PyKE
christinahedges 83f5a6b
Merge branch 'master' of https://github.com/keplerGO/PyKE
christinahedges df2c9c4
Merge branch 'master' of https://github.com/keplerGO/PyKE
christinahedges f13417b
Fixed CBV keplerlightcurvefile issue
christinahedges 27e960f
Merge branch 'master' of https://github.com/keplerGO/PyKE into cbv-fixes
christinahedges faba9b9
rename lc_file --> lightcurve
mirca 20602a2
type checking for aperture_mask
mirca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -228,11 +228,14 @@ def to_lightcurve(self, aperture_mask='pipeline'): | |
centroid_col=centroid_col, | ||
centroid_row=centroid_row, | ||
quality=self.quality, | ||
quality_bitmask=self.quality_bitmask, | ||
quality_mask=self._quality_mask(self.quality_bitmask), | ||
channel=self.channel, | ||
campaign=self.campaign, | ||
quarter=self.quarter, | ||
mission=self.mission, | ||
cadenceno=self.cadenceno) | ||
cadenceno=self.cadenceno, | ||
keplerid=self.keplerid) | ||
|
||
def centroids(self, aperture_mask='pipeline'): | ||
"""Returns centroids based on sample moments. | ||
|
@@ -250,9 +253,9 @@ def centroids(self, aperture_mask='pipeline'): | |
col_centr, row_centr : tuple | ||
Arrays containing centroids for column and row at each cadence | ||
""" | ||
if aperture_mask == 'pipeline': | ||
if aperture_mask is 'pipeline': | ||
aperture_mask = self.pipeline_mask | ||
elif aperture_mask == 'all': | ||
elif aperture_mask is 'all': | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see above |
||
mask = ~np.isnan(self.hdu[1].data['FLUX'][100]) | ||
aperture_mask = np.ones((self.shape[1], self.shape[2]), | ||
dtype=bool) * mask | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct, should be
==
.is
checks ifaperture_mask
and'pipeline'
are the sameobject
, whereas==
checks for the value.