KeplerCBVCorrector can now take a KeplerLightCurve Object #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis-CI complains are legit |
mirca
reviewed
Jan 4, 2018
pyke/targetpixelfile.py
Outdated
| @@ -250,9 +253,9 @@ def centroids(self, aperture_mask='pipeline'): | |||
| col_centr, row_centr : tuple | |||
| Arrays containing centroids for column and row at each cadence | |||
| """ | |||
| if aperture_mask == 'pipeline': | |||
| if aperture_mask is 'pipeline': | |||
There was a problem hiding this comment.
this is not correct, should be ==. is checks if aperture_mask and 'pipeline' are the same object, whereas == checks for the value.
mirca
reviewed
Jan 4, 2018
pyke/targetpixelfile.py
Outdated
| aperture_mask = self.pipeline_mask | ||
| elif aperture_mask == 'all': | ||
| elif aperture_mask is 'all': |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with CBVs where you couldn't pass a 'KeplerLightCurve' object.
Now you can pass a 'KeplerLightCurve' object, 'KeplerLightCurveFile' object or a string (as before). This is a bit of a work around and I don't like it. The best fix is to compare time stamps.