Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release tests #37

Merged
merged 3 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/bump-version-and-create-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,20 @@ jobs:
tag: ${{ needs.compute-version.outputs.new_tag }}
body: ${{ github.event.pull_request.body }}


build-and-run-release-tests:
needs: [compute-version, create-release]
runs-on: ubuntu-latest
steps:
- name: Build release test Docker image
uses: docker/build-push-action@v6
with:
build-args: |
RELEASE_DOWNLOAD_URL=https://github.com/KIT-MRT/util_caching/releases/download/${{ needs.compute-version.outputs.new_tag }}
push: false
tags: release_tester
target: release_test

- name: Run unit tests with/against released version
run: |
docker run --rm release_tester
24 changes: 0 additions & 24 deletions .github/workflows/run-release-tests.yaml

This file was deleted.

4 changes: 3 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,12 @@ RUN cmake .. && \

FROM base AS release_test

ARG RELEASE_DOWNLOAD_URL=https://github.com/KIT-MRT/util_caching/releases/latest/download/

# This downloads the latest util_caching debian release and adds it to the docker image
# This "bloats" the image. But otherwise, we'd have to installing wget and ca-certificates
# temporarily to download and install the package in one docker layer…
ADD https://github.com/KIT-MRT/util_caching/releases/latest/download/libutil-caching-dev.deb /tmp/debfiles/
ADD ${RELEASE_DOWNLOAD_URL}/libutil-caching-dev.deb /tmp/debfiles/

# Install util_caching from release debian package
RUN dpkg -i /tmp/debfiles/*.deb && \
Expand Down