Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release tests #37

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix release tests #37

merged 3 commits into from
Nov 12, 2024

Conversation

orzechow
Copy link
Member

@orzechow orzechow commented Nov 12, 2024

This fixes the release test GitHub Action workflow introduced in #36

#patch

@orzechow orzechow force-pushed the test_released_deb_package branch 5 times, most recently from 47a437d to 601dc0f Compare November 12, 2024 12:36
@orzechow
Copy link
Member Author

orzechow commented Nov 12, 2024

@ll-nick Also, for some reason the #patch trigger does not work. Instead the workflow creates minor bumps

I guess that's only a problem in the test runs here, because the action only reads the commit history.
In a merged PR, this would include the PR description in the merge commit and thus should work

@ll-nick
Copy link
Collaborator

ll-nick commented Nov 12, 2024

@ll-nick Also, for some reason the #patch trigger does not work. Instead the workflow creates minor bumps

Did you add that to a commit message? It has to be there, the PR description is not being used in that particular action.

@orzechow
Copy link
Member Author

@orzechow orzechow force-pushed the test_released_deb_package branch from c9e0166 to 8bdb541 Compare November 12, 2024 12:48
@orzechow orzechow requested a review from ll-nick November 12, 2024 12:48
Copy link
Collaborator

@ll-nick ll-nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason why this shouldn't work but that is a sentence I have said probably 200 times in the last couple of days. Good luck 🍀

.github/workflows/bump-version-and-create-release.yaml Outdated Show resolved Hide resolved
.github/workflows/bump-version-and-create-release.yaml Outdated Show resolved Hide resolved
@orzechow orzechow merged commit 3e4d78f into main Nov 12, 2024
1 check passed
@orzechow orzechow deleted the test_released_deb_package branch November 12, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants