Fix a possible UB in kislager::do_static_cast

The getter argument should be const-ref for now See this bug-report: arximboldi/lager#160
KDE · Aug 1, 2024 · f4e2b00 · f4e2b00
1 parent 1f3ff8f
commit f4e2b00
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/libs/global/KisLager.h b/libs/global/KisLager.h
@@ -65,9 +65,9 @@ constexpr auto scale_real_to_int = [] (qreal multiplier) {
         );
 };
 
-template <typename Src, typename Dst>
+template <typename Src, typename Dst, typename SrcConstRef = std::add_lvalue_reference_t<std::add_const_t<Src>>>
 auto do_static_cast = lager::lenses::getset(
-    [] (Src value) { return static_cast<Dst>(value); },
+    [] (SrcConstRef value) { return static_cast<Dst>(value); },
     [] (Src, Dst value) { return static_cast<Src>(value); }
     );