Skip to content

Commit

Permalink
Remove QT_NO_FOREACH and -DQT_NO_CAST_FROM_ASCII
Browse files Browse the repository at this point in the history
We have way too many QString s = QString("asdadas"); to port all
of that to QStringLiteral or QString::fromUtf8, and way to many
Q_FOREACH instances to port all of that to something probably
works in a slightly different way.

Both are now default in Qt6...
  • Loading branch information
Halla Rempt committed Aug 1, 2024
1 parent 105d812 commit 1f3ff8f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,12 @@ add_definitions(
-DQT_USE_FAST_OPERATOR_PLUS
)

remove_definitions(
-DQT_NO_CAST_FROM_ASCII
-DQT_NO_FOREACH
)


# MSVC is unable to disambiguate between definitions of QVector<QPointF>
# and QPolygonF. This is a known upstream bug e.g.:
# - https://phabricator.kde.org/D21314
Expand Down

0 comments on commit 1f3ff8f

Please sign in to comment.