Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify use of an atol when comparing to zero #692

Merged
merged 29 commits into from
Dec 25, 2023

Improve formatting.

869f0a3
Select commit
Loading
Failed to load commit list.
Merged

Unify use of an atol when comparing to zero #692

Improve formatting.
869f0a3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 18, 2023 in 0s

5.49% (-94.09%) compared to b2d83b3

View this Pull Request on Codecov

5.49% (-94.09%) compared to b2d83b3

Details

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (b2d83b3) 99.57% compared to head (869f0a3) 5.49%.

❗ Current head 869f0a3 differs from pull request most recent head 9f6f544. Consider uploading reports for the commit 9f6f544 to get more accurate results

Files Patch % Lines
src/statistics.jl 0.00% 23 Missing ⚠️
src/manifolds/Circle.jl 0.00% 5 Missing ⚠️
src/manifolds/SymplecticStiefel.jl 0.00% 5 Missing ⚠️
src/manifolds/CenteredMatrices.jl 0.00% 4 Missing ⚠️
src/manifolds/CholeskySpace.jl 0.00% 4 Missing ⚠️
src/manifolds/KendallsPreShapeSpace.jl 0.00% 4 Missing ⚠️
src/manifolds/MultinomialDoublyStochastic.jl 0.00% 4 Missing ⚠️
src/manifolds/SphereSymmetricMatrices.jl 0.00% 4 Missing ⚠️
src/manifolds/Symmetric.jl 0.00% 4 Missing ⚠️
src/manifolds/Symplectic.jl 0.00% 4 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #692       +/-   ##
==========================================
- Coverage   99.57%   5.49%   -94.09%     
==========================================
  Files         108     108               
  Lines       10677   10503      -174     
==========================================
- Hits        10632     577    -10055     
- Misses         45    9926     +9881     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.