Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify use of an atol when comparing to zero #692

Merged
merged 29 commits into from
Dec 25, 2023

Improve formatting.

869f0a3
Select commit
Loading
Failed to load commit list.
Merged

Unify use of an atol when comparing to zero #692

Improve formatting.
869f0a3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 18, 2023 in 1s

4.12% of diff hit (target 99.57%)

View this Pull Request on Codecov

4.12% of diff hit (target 99.57%)

Annotations

Check warning on line 86 in src/groups/addition_operation.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/groups/addition_operation.jl#L86

Added line #L86 was not covered by tests

Check warning on line 93 in src/groups/addition_operation.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/groups/addition_operation.jl#L93

Added line #L93 was not covered by tests

Check warning on line 52 in src/groups/special_linear.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/groups/special_linear.jl#L52

Added line #L52 was not covered by tests

Check warning on line 60 in src/groups/special_linear.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/groups/special_linear.jl#L60

Added line #L60 was not covered by tests

Check warning on line 38 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L38

Added line #L38 was not covered by tests

Check warning on line 45 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L45

Added line #L45 was not covered by tests

Check warning on line 64 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L64

Added line #L64 was not covered by tests

Check warning on line 72 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L72

Added line #L72 was not covered by tests

Check warning on line 31 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L31

Added line #L31 was not covered by tests

Check warning on line 39 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L39

Added line #L39 was not covered by tests

Check warning on line 62 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L62

Added line #L62 was not covered by tests

Check warning on line 69 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L69

Added line #L69 was not covered by tests

Check warning on line 81 in src/manifolds/Circle.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Circle.jl#L81

Added line #L81 was not covered by tests

Check warning on line 88 in src/manifolds/Circle.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Circle.jl#L88

Added line #L88 was not covered by tests

Check warning on line 169 in src/manifolds/Circle.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Circle.jl#L169

Added line #L169 was not covered by tests

Check warning on line 549 in src/manifolds/Circle.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Circle.jl#L548-L549

Added lines #L548 - L549 were not covered by tests

Check warning on line 88 in src/manifolds/Elliptope.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Elliptope.jl#L88

Added line #L88 was not covered by tests

Check warning on line 97 in src/manifolds/Elliptope.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Elliptope.jl#L97

Added line #L97 was not covered by tests

Check warning on line 128 in src/manifolds/EssentialManifold.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/EssentialManifold.jl#L128

Added line #L128 was not covered by tests

Check warning on line 135 in src/manifolds/EssentialManifold.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/EssentialManifold.jl#L135

Added line #L135 was not covered by tests

Check warning on line 327 in src/manifolds/FixedRankMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/FixedRankMatrices.jl#L327

Added line #L327 was not covered by tests

Check warning on line 335 in src/manifolds/FixedRankMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/FixedRankMatrices.jl#L335

Added line #L335 was not covered by tests

Check warning on line 341 in src/manifolds/FixedRankMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/FixedRankMatrices.jl#L341

Added line #L341 was not covered by tests

Check warning on line 181 in src/manifolds/GeneralUnitaryMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/GeneralUnitaryMatrices.jl#L181

Added line #L181 was not covered by tests

Check warning on line 283 in src/manifolds/GeneralizedGrassmann.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/GeneralizedGrassmann.jl#L283

Added line #L283 was not covered by tests