Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct detection for Vite build vs serve mode #595

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

draotth
Copy link
Contributor

@draotth draotth commented Aug 18, 2023

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix a bug where vite build -w produces /@imagetools/* URLs, when it should be producing image outputs.

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)

  • Other information:

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

🦋 Changeset detected

Latest commit: 12930b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-imagetools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #595 (12930b4) into main (76ccb91) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files          32       32           
  Lines        1104     1104           
  Branches      185      185           
=======================================
  Hits         1037     1037           
  Misses         67       67           
Flag Coverage Δ
imagetools-core 96.66% <ø> (ø)
vite-imagetools 79.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vite/src/index.ts 79.06% <100.00%> (ø)

@benmccann benmccann merged commit e4bba3c into JonasKruckenberg:main Aug 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants