Build and build -w output differs

[draotth]

Problem

The outputted images for vite build -w have the /@imagetools/* reference, which consumers of my library cannot interpret or find.

My workaround

Running build (no watch) with chokidar to publish updates to calc locally works, but has it's own problems (e.g. production build, no HMR, etc).

I statically copy the images from the npm package (I'm using chokidar/yalc to publish the changes when the dist folder of the Component Lib changes).

Possible solutions

1. Change (or allow configuration of) imagetools to output
2. Let me know the location of the /@imagetools files, and I can try to see if I can manually copy those in dev mode.

[benmccann]

That's probably coming from this line:

imagetools/packages/vite/src/index.ts

Line 113 in 76ccb91

if (this.meta.watchMode) {

That line should probably be updated to check if we're in build mode or dev mode instead. I don't know that I'll get to this for awhile, but a PR would be welcome. I can review and merge quickly if you'd like to take stab at it

[draotth]

Switched to use viteConfig.isProduction, which has the following values:

1. vite build - true
2. vite build -w - true
3. vite dev - false

However, the unit tests using the Javascript API seem to have this as always false, even if you set mode: 'production'

This, of course, breaks the output paths for all the tests. Any thoughts off-hand?

[draotth]

This is because NODE_ENV is set while unit testing to production.

This leads me to think that isProduction is less reliable for this and perhaps other unknown reasons.

(viteConfig.command !== 'build') seems much more reliable for the use case here.

[draotth]

Created a PR

[benmccann]

Thank you for the fix! #595

[draotth]

Thanks for the fast responses!