Introduce Side Pane Attributes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscarponi
force-pushed
the
fabrizio.scarponi/PKGS-1104-Platform-panel
branch
from
9bdbb0f to
4aee879
Compare
fscarponi
force-pushed
the
fabrizio.scarponi/PKGS-1104-Platform-panel
branch
from
4aee879 to
0b31120
Compare
lamba92
requested changes
Dec 21, 2023
...in/src/main/kotlin/com/jetbrains/packagesearch/plugin/ui/model/infopanel/InfoPanelContent.kt
Outdated
Show resolved
Hide resolved
...in/src/main/kotlin/com/jetbrains/packagesearch/plugin/ui/model/infopanel/InfoPanelContent.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/jetbrains/packagesearch/plugin/ui/model/infopanel/InfoPanelContentEvent.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/jetbrains/packagesearch/plugin/ui/model/infopanel/InfoPanelContentEvent.kt
Outdated
Show resolved
Hide resolved
| onClick = { | ||
| //this event should be handled when you click on a selected package to refresh side panel content | ||
| if (isSelected ) onPackageListItemEvent( | ||
| PackageListItemEvent.InfoPanelEvent.OnSelectedPackageClick(content.id) |
There was a problem hiding this comment.
What's the behaviour here? Afair changing the selection is handled by the SelectableLazyColumn callback for selection change. Why do we need to add an onClick here?
There was a problem hiding this comment.
1 - select package X (the side panel shows the package details) -> onSelectionChange() does the job
2 - click on a header badge (side pane shows the platforms) -> onClick for badge does the job
3 - click again on package X (the side panel shows the header's platform details) -> onSelectionChange() has not been called cause the selection is not changed
possible solutions:
-> make headers selectable -> is not what we want (will not fix anyway the multiSelection Interaction)
-> handle this corner case -> when someone clicks on already selected package, set the correct content on the side panel
plugin/src/main/kotlin/com/jetbrains/packagesearch/plugin/ui/panels/side/HeaderAttributesTab.kt
Outdated
Show resolved
Hide resolved
plugin/src/main/kotlin/com/jetbrains/packagesearch/plugin/ui/panels/side/HeaderAttributesTab.kt
Outdated
Show resolved
Hide resolved
|
Also, you need to update to the latest submodule of api-models. |
fscarponi
force-pushed
the
fabrizio.scarponi/PKGS-1104-Platform-panel
branch
2 times, most recently
from
5f9bad1 to
ebb58df
Compare
…esTab Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation.
fscarponi
force-pushed
the
fabrizio.scarponi/PKGS-1104-Platform-panel
branch
from
ebb58df to
e228959
Compare
fscarponi
commented
Jan 10, 2024
plugin/build.gradle.kts
Outdated
| @@ -56,6 +56,7 @@ dependencies { | |||
| implementation(compose.desktop.windows_x64) | |||
| implementation(packageSearchCatalog.kotlinx.serialization.core) | |||
| implementation(packageSearchCatalog.jewel.bridge.ij233) | |||
| implementation(packageSearchCatalog.jewel.standalone) | |||
There was a problem hiding this comment.
@lamba92 Standalone is mandatory for run the Compose Preview (i'm not sure if we need it as implementation)
| object PackageSearchColors { | ||
| object Backgrounds { | ||
| fun packageItemHeader(): Color = | ||
| pickComposeColorFromLaf("ToolWindow.HeaderTab.selectedInactiveBackground") |
There was a problem hiding this comment.
it seems ok in 241, but I'm expecting a different result in 232 and 233. This will be fixed in related branches (expecting that 232 and 233 should be fixed in different ways)
| onClick = { | ||
| //this event should be handled when you click on a selected package to refresh side panel content | ||
| if (isSelected ) onPackageListItemEvent( | ||
| PackageListItemEvent.InfoPanelEvent.OnSelectedPackageClick(content.id) |
There was a problem hiding this comment.
1 - select package X (the side panel shows the package details) -> onSelectionChange() does the job
2 - click on a header badge (side pane shows the platforms) -> onClick for badge does the job
3 - click again on package X (the side panel shows the header's platform details) -> onSelectionChange() has not been called cause the selection is not changed
possible solutions:
-> make headers selectable -> is not what we want (will not fix anyway the multiSelection Interaction)
-> handle this corner case -> when someone clicks on already selected package, set the correct content on the side panel
fscarponi
added a commit
that referenced
this pull request
Jan 10, 2024
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
fscarponi
added a commit
that referenced
this pull request
Jan 11, 2024
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
fscarponi
added a commit
that referenced
this pull request
Jan 11, 2024
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
This was referenced Jan 11, 2024
fscarponi
added a commit
that referenced
this pull request
Jan 11, 2024
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
lamba92
pushed a commit
that referenced
this pull request
Jan 11, 2024
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
This was referenced Jan 11, 2024
lamba92
pushed a commit
that referenced
this pull request
Jan 11, 2024
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
lamba92
pushed a commit
that referenced
this pull request
Jan 11, 2024
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PKGS 1104
This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes.
A click event handler for the selected packages is also added to refresh the side panel content.
A new event for package selection has been placed in 'PackageListItemEvent'.
Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation.
To Do: